Added preferences for shell & shell arguments

[owlJaeger]

Signed-off-by: Luca Jaeger owl.jaeger@gmail.com

What it does

Adds an easy way to control what shell or what shell arguments to use for the Terminal by adding preferences and prefer these over this.options.shellPath and this.options.shellArgs.

How to test

Add terminal.integrated.shell.{os} or terminal.integrated.shellArgs.{os} to the preferences.
Example:

{
  "terminal.integrated.shell.windows": "pwsh.exe",
  "terminal.integrated.shellArgs.windows": [
    "-nop"
  ]
}

I have pwsh.exe in my path env variable, but absolute paths work too.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@owlJaeger are these the preferences you are attempting to add:

[owlJaeger]

Yes, these are what I am looking for. I've updated this PR to include terminal.integrated.shell.${os} and terminal.integrated.shellArgs.${os} and not just one for all operating systems.

[akosyakov]

Please make sure to align and test that they are compatible with VS Code if present.

[owlJaeger]

Please make sure to align and test that they are compatible with VS Code if present.

I've tested it in the theia workspace and setting terminal.integrated.shell.windows to pwsh.exe inside .vscode while theia defaults to cmd.exe and the terminal started with powershell. So I see this as compatible? Is this what you meant?

[akosyakov]

@owlJaeger that's good, each PR should pass https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#landing-pr someone will test and approve it

[owlJaeger]

Looking forward to using it.

[owlJaeger]

@akosyakov @vince-fugnitto I've now updated this PR. I am unsure about the naming of some stuff. I've tested it and it looks like it's fully functional on windows.

[akosyakov]

My concerns were addressed. We need to test it though. It would be also good if @marechal-p look at the shell process. I think you changed it the last.

[akosyakov]

I've tested on Linux with:

"terminal.integrated.shellArgs.linux": [
    "-c",
    "echo 'Hello World' && sleep 999999999"
  ]

and it worked well.

@vince-fugnitto @marechal-p Any concerns to merge it?

[vince-fugnitto]

@vince-fugnitto @marechal-p Any concerns to merge it?

No I don't believe so :) I've restarted the build and it's all green.
Thank you very much for your contribution @owlJaeger!

[JPinkney]

Just tried it out on osx and everything is working!

[akosyakov]

@vince-fugnitto @JPinkney thank you for double checking, merging 🚀