Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer plugin contributions (preferences and tasks) #7676

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 27, 2020

What it does

TODO:

  • fix preference tests to check that there is not changes if schema set and unset in the same tick and there are if in different ticks
  • make sure that update/replace configuration calls from the extension host process are not resolved before preference changes are propagated to the extension host

How to test

git clone https://github.com/akosyakov/jupyterlab.git \
cd jupyterlab/ \
git checkout ak/fetch_tasks
yarn start ../../../jupyterlab/jlab.theia-workspace

Testing task fetching:

cd plugins/ \
git clone https://github.com/akosyakov/vscode-fetch-tasks-test.git \
cd vscode-fetch-tasks-test/ \
yarn && yarn compile

Review checklist

Reminder for reviewers

@akosyakov akosyakov added preferences issues related to preferences performance issues related to performance tasks issues related to the task system plug-in system issues related to the plug-in system multi-root issues related to multi-root support labels Apr 27, 2020
@akosyakov akosyakov marked this pull request as draft April 28, 2020 10:16
@akosyakov akosyakov force-pushed the ak/defer_plugin_contributions branch from 06a6b5c to aba5392 Compare April 28, 2020 14:31
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/defer_plugin_contributions branch from aba5392 to fd880ef Compare April 29, 2020 09:08
@akosyakov akosyakov marked this pull request as ready for review April 29, 2020 09:47
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/defer_plugin_contributions branch from c8efe84 to 8fb8bce Compare April 29, 2020 10:04
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that that registering plugin contributions is fast

handleContributions took only 327 ms.

use Hello World to see all found tasks in output view

✅ I see a long list of tasks, also in the Run Task dialog.

@akosyakov akosyakov merged commit 9286ffe into master Apr 30, 2020
@akosyakov akosyakov deleted the ak/defer_plugin_contributions branch April 30, 2020 07:15
@RomanNikitenko
Copy link
Contributor

@akosyakov

simplify $fetchTasks by removing filtering duplicate tasks

I played with your changes this morning and I think the filtering was related to customized tasks.
The difference is:

  • before your changes it returned configured and detected tasks
  • with your changes it returns configured, detected and customized tasks

To reproduce it with your plugin I modified a little your plugin to see whole configuration, not only name and source, then:

  • use Hello World to see all found tasks in output view
  • pay attention on number of tasks
  • go to Terminal -> Configure task and configure a few tasks
  • use Hello World to see all found tasks in output view
  • pay attention on number of tasks

I don't know how vs code behaves for this case.
Sorry for the delay, maybe this comment will be useful for #7681.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-root issues related to multi-root support performance issues related to performance plug-in system issues related to the plug-in system preferences issues related to preferences tasks issues related to the task system
Projects
None yet
3 participants