-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defer plugin contributions (preferences and tasks) #7676
Conversation
06a6b5c
to
aba5392
Compare
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
aba5392
to
fd880ef
Compare
packages/core/src/browser/preferences/preference-service.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
c8efe84
to
8fb8bce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check that that registering plugin contributions is fast
✅ handleContributions
took only 327 ms.
use Hello World to see all found tasks in output view
✅ I see a long list of tasks, also in the Run Task dialog.
I played with your changes this morning and I think the filtering was related to customized tasks.
To reproduce it with your plugin I modified a little your plugin to see whole configuration, not only
I don't know how vs code behaves for this case. |
What it does
$fetchTasks
by removing filtering duplicate tasks. Testing showed that VS Code does not do it (see [plugin] fetching tasks is slow for big multi-root workspaces #7672 (comment)) and even after removing our implementation fails to return duplicate tasks. That's apparently an issue how the task extension treats the task identity: create tasks VS Code API compatibility tests #7681 (comment)TODO:
How to test
git clone https://github.com/akosyakov/jupyterlab.git \ cd jupyterlab/ \ git checkout ak/fetch_tasks
Testing task fetching:
Hello World
to see all found tasks in output viewReview checklist
Reminder for reviewers