Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-root: fix statusbar color #7688

Merged
merged 1 commit into from
Apr 29, 2020
Merged

multi-root: fix statusbar color #7688

merged 1 commit into from
Apr 29, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #7687

Fixes an issue with the theming of the statusbar when in a multiple-root workspace (file) without any roots present. Previously, the application would decorate the statusbar incorrectly as if no workspace is present.

Single-Root Workspace Opened:

Screen Shot 2020-04-28 at 1 43 05 PM

Multiple-Root Workspace Opened (No Roots):

Screen Shot 2020-04-28 at 1 30 23 PM

Closed Workspace:

Screen Shot 2020-04-28 at 1 30 04 PM

How to test

  1. open a multple-root workspace with two roots
  2. remove both roots from the workspace (the statusbar should be colored correctly)
  3. open theia as a workspace (the statusbar should be colored correctly)
  4. execute the command close workspace (the statusbar should be colored correctly as if no workspace is opened)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

- fixes the statusbar theme color when in a multiple-root workspace without
any roots present. In this particular case, a workspace is successfully opened but
no roots are present.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the multi-root issues related to multi-root support label Apr 28, 2020
@vince-fugnitto vince-fugnitto self-assigned this Apr 28, 2020
@akosyakov akosyakov requested a review from jbicker April 29, 2020 07:21
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thanks!

@vince-fugnitto vince-fugnitto merged commit 262f811 into master Apr 29, 2020
@vince-fugnitto vince-fugnitto deleted the vf/gh-7687 branch April 29, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-root issues related to multi-root support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi-root: incorrect statusbar color when in a multi-root workspace without roots
2 participants