Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] don't require non existing plugin main #7852

Merged
merged 1 commit into from
May 25, 2020
Merged

[vscode] don't require non existing plugin main #7852

merged 1 commit into from
May 25, 2020

Conversation

svenefftinge
Copy link
Contributor

What it does

Avoids logging errors when plugin-host-rpc tries to load non existing plugin entry scripts.

How to test

Install an extension without a main entry point.
E.g. https://marketplace.visualstudio.com/items?itemName=wingrunr21.vscode-ruby

Review checklist

Reminder for reviewers

@svenefftinge
[vscode] don't require non existing plugin main
b641010 
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label May 25, 2020
akosyakov
akosyakov approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that extension contribution are loaded and no errors during acitvation

@svenefftinge svenefftinge merged commit 8bb713f into master May 25, 2020
@svenefftinge svenefftinge deleted the se_optional_vscode_main branch May 25, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenefftinge @akosyakov