[scm] refesh on widget activation #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #7873 Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
se/scm-widget-fix
branch
from
d84737c to
98f3525
Compare
|
Suggestion: In this PR, there should be 1-2 lines changes, not the whole file. Everyone should use the same format, it would make it easier to identify the changes while performing the review. |
akosyakov
reviewed
May 25, 2020
| @@ -149,6 +149,7 @@ export class ScmWidget extends BaseWidget implements StatefulWidget { | |||
|
|
|||
| protected onActivateRequest(msg: Message): void { | |||
| super.onActivateRequest(msg); | |||
| this.refresh(); | |||
There was a problem hiding this comment.
I wonder should not we rather move it to onAfterShow, so it gets refreshed whenever the widget is revealed not focused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes #7873
How to test
Try reproduce #7873
Review checklist
Reminder for reviewers