[monaco] only focus an editor if it's revealed

[akosyakov]

What it does

• fix input not at force editor #7902: see input not at force editor #7902 (comment)

How to test

• test that different kind of editors are properly activated and receive keystrokes:
  • editor widget
  • diff editor widget
  • debug console input
  • breakpoint expression editor
  • peek reference editor
• test that switching editors while Go to Symbol... or Go to line quick palette are opened closes the panel and gives the focus to the proper editor

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

Somehow, I managed to break it 😕 I extracted that part from the screencast but it is 100MB, I cannot upload it. It must be related to toggling the Explorer. After that I could not write into the editor.

[spoenemann]

I noticed that opening an editor from search results in the Search or Reference views does not focus the editor. Is that related to this change?

[akosyakov]

I noticed that opening an editor from search results in the Search or Reference views does not focus the editor. Is that related to this change?

it is intended that you can navigate with keyboard between results and preview them.

[akosyakov]

@kittaakos on Mac, I use licecap it can create small gifs

[spoenemann]

I noticed that opening an editor from search results in the Search or Reference views does not focus the editor. Is that related to this change?

it is intended that you can navigate with keyboard between results and preview them

I would expect a preview editor in that case. Double-click on a search result should focus the respective code part. But that's unrelated to this PR, I found no other issues 👍

[kittaakos]

I managed to break it

Because I'm an idiot and was checking a different version. I could reproduce the issue with the other version:

but not with the changes from this PR. 👍

[kittaakos]

I think this change fixes this too: #6298

[akosyakov]

I think this change fixes this too: #6298

@kittaakos Should we close it? Did you verify it?