Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofix: upgrade-nvm-tools #7924

Conversation

autofix-bot
Copy link

Signed-off-by: Autofix <autofix-bot@users.noreply.github.com>
@jankeromnes
Copy link
Member

jankeromnes commented May 29, 2020

This was me, as an experiment. If it's unhelpful I can turn it off.

Autofix is a tiny tool and service I built that regularly checks for known code defects (mostly small things like outdated version strings and trailing spaces) and can send Pull Requests automatically. It aims to propose small valuable fixes with no false positives to limit the burden on reviewers.

I'm just a bit unsure about the ECA, as a bot obviously can't sign it. Can I sign the ECA for the bot? Or should I send these automated PRs in my name? Any thoughts/ideas here are very welcome. I hope this can be useful (but again, it it's not, I'm happy to disable it).

@akosyakov
Copy link
Member

@jankeromnes It would be good to propose it on dev meeting first.

BTW can such bots sign ECA if not i doubt we can merge it.

@akosyakov akosyakov added the quality issues related to code and application quality label May 29, 2020
@jankeromnes
Copy link
Member

@jankeromnes It would be good to propose it on dev meeting first.

Agreed, I'll add this topic to the next meeting's agenda.

BTW can such bots sign ECA if not i doubt we can merge it.

I think they can't, the ECA explicitly requests that you sign using your real name (no pseudonym, no anonymous contributions) so I guess bots are not allowed to sign.

@vince-fugnitto
Copy link
Member

@jankeromnes It would be good to propose it on dev meeting first.

Agreed, I'll add this topic to the next meeting's agenda.

@jankeromnes maybe a compromise would be to create issues with 'help wanted' and 'good first issue' which will both track issues and attract new contributors?

@jankeromnes
Copy link
Member

@jankeromnes maybe a compromise would be to create issues with 'help wanted' and 'good first issue' which will both track issues and attract new contributors?

I really like the idea to open issues tagged 'help wanted' or 'good first issue'! Thanks for the suggestion. The autofix bot can't yet automatically open issues, but maybe this can be implemented, or we could close automated Autofix PRs and manually reference them in new issues.

For now, I've grouped the current automated fixes in #7945, because at least the Node.js upgrade seemed important enough not to delay further.

@jankeromnes jankeromnes closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants