-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-7767: Added context menu for input and textArea #7943
Conversation
packages/core/src/electron-browser/menu/electron-context-menu-renderer.ts
Outdated
Show resolved
Hide resolved
Closes #7767. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work really well! 👍 I verified both inputs and textarea
- the search-in-workspace input
- the scm textarea
I think we can also use this as an example to create a similar context-menu for the browser target.
Yes, but I was thinking we should do it for the browser target so that:
|
Nice, any electron screenshots? |
I do not like the idea; I am pretty happy with the native one. It does all I need, in fact, I would like to use the native one in electron too, but it's not possible as far as I know. The only reason I did this change is to be able to paste a password into the Of course, if you think this would add value to Theia, feel free to open a separate issue for discussion. If it's just something we could do, but there is no good reason doing it, let's just not do it. |
I think in general we should use native implementations wherever possible. It feels more natural to the user. |
Closes #7767.
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
Enables the context menu in
input
andtextArea
elements. For electron only.How to test
input
andtextArea
,Select All
,Cut
,Copy
, andPaste
.Review checklist
Reminder for reviewers
Please keep in mind, that the input value will be automatically selected, so when you paste, the original value will be replaced. See here: microsoft/vscode#99126 (comment), I was confused by the
SCM
"input" for instance, but that's a monaco editor eventually.