Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VS Code workbench.view.explorer command #7965

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Jun 4, 2020

What it does

This changes proposal adds simple implementation for the VS Code workbench.view.explorer command command. [1]

[1] microsoft/vscode/src/vs/workbench/contrib/files/browser/files.contribution.ts#L44-L57

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

How to test

There is two ways to check the PR:

  1. Using custom plugin that calls this command: workbench-files-action-focusFilesExplorer

  2. Using Didact extension. It will call under the hood this command and the previously implemented copyFilePath:

explorer

Review checklist

Reminder for reviewers

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added enhancement issues that are enhancements to current functionality - nice to haves Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility commands issues related to application commands labels Jun 4, 2020
@vzhukovs vzhukovs self-assigned this Jun 4, 2020
@azatsarynnyy
Copy link
Member

Shouldn't it be workbench.view.explorer command which is called here in your sample?
Anyway, I've tested with both of them: Theia's and VS Code one. Works as expected.

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Jun 5, 2020

Shouldn't it be workbench.view.explorer command which is called here in your sample?
Anyway, I've tested with both of them: Theia's and VS Code one. Works as expected.

Yep, you're right. I've updated test plugin.

@vzhukovs vzhukovs merged commit d9a0973 into master Jun 5, 2020
@vzhukovs vzhukovs deleted the workbench_view_explorer branch June 5, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands enhancement issues that are enhancements to current functionality - nice to haves Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants