feat(messaging): Create container in its own method to easier subclassing #8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing Change-Id: Idb2a1fde259eefd8c0485a8632233565f537b5a5 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
akosyakov
reviewed
Jun 15, 2020
| protected getConnectionChannelHandlers(socket: ws): MessagingContribution.ConnectionHandlers<WebSocketChannel> { | ||
| const connectionContainer = this.container.createChild(); | ||
| protected createSocketContainer(socket: ws): Container { | ||
| const connectionContainer: Container = this.container.createChild() as Container; |
There was a problem hiding this comment.
(nit) ts should be able infer types here
There was a problem hiding this comment.
yes this is what I was thinking as well but without the as Container I've
src/node/messaging/messaging-contribution.ts(182,15): error TS2740: Type 'Container' is missing the following properties from type 'Container': _middleware, _bindingDictionary, _snapshots, _metadataReader, and 5 more.
There was a problem hiding this comment.
@akosyakov I think it's because there
https://github.com/inversify/InversifyJS/blob/ac59f754fcc4bc29d77804ebb5ae0e8bce90c46d/src/container/container.ts#L220
it's returning Container and not interfaces.Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Move code in its own method to make it easy when subclassing
It allows to grab container created without requiring to override the full method
How to test
Nothing should break
Review checklist
Reminder for reviewers
Change-Id: Idb2a1fde259eefd8c0485a8632233565f537b5a5
Signed-off-by: Florent Benoit fbenoit@redhat.com