-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: include registration of view containers #8034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well
Thanks @vince-fugnitto
packages/plugin-ext/src/main/browser/view/plugin-view-registry.ts
Outdated
Show resolved
Hide resolved
I find it confusing without grouping. Maybe we can add |
@akosyakov I believe that That is why I initially proposed #8026, to try and group based on the actual containers and contributed views, but the step further would be to group based on where they are contributed. For example, for views contributed to the |
ok, let's do it in another PR, but take care that view containers are only activated, not toggled |
Fixes: #8016 The following pull-request updates the plugin system to include the registration of `view containers` in the `open view` prefix menu. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
7fa70e5
to
558df2e
Compare
@lmcbout do you mind re-testing, I've updated the 'how to test' section following the recent changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
No toggling for the view when re-selectiong View -> open-view
The other views DO not TOGGLE either
Tested on Ubuntu with Chrome and FireFox
I'll merge tomorrow if there are no objections. |
What it does
Fixes: #8016
The following pull-request updates the plugin system to include
the registration of
view containers
in theopen view
prefix menu.How to test
gitlens
view if it is visibleopen view
prefix quick-open menu (opened by theview
>open view
menu)gitlens
, and verify that the view is opened correctlyopen view
again selectinggitlens
(the view should remain open (not toggle))Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com