Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode-languageserver-protocol as a dependency #8036

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Add vscode-languageserver-protocol as a dependency #8036

merged 1 commit into from
Jun 18, 2020

Conversation

mikael-desharnais
Copy link
Contributor

@mikael-desharnais mikael-desharnais commented Jun 17, 2020

What it does

Fixes: #8030

The following pull-request adds the vscode-languageserver-protocol dependency to @theia/core since it is used by multiple extensions and is never added as a depependency.

How to test

  • the build should successfully pass (no change in functionality)
  • applications which have a subset of extensions will now work correctly

Review checklist

Reminder for reviewers

Signed-off-by: Mikael Desharnais mikael.desharnais@gmail.com

Signed-off-by: Mikael Desharnais <mikael.desharnais@gmail.com>
@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Jun 17, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I'll wait for CI to pass before merging.
I updated the pull-request description, as I mentioned before please keep it intact and fill out the necessary information for future contributions.

@akosyakov
Copy link
Member

akosyakov commented Jun 18, 2020

@vince-fugnitto I don't see any changes to yarn.lock. I don't think we need a CQ. It was just a missing declaration, dependency was already installed via other packages.

@vince-fugnitto
Copy link
Member

@vince-fugnitto I don't see any changes to yarn.lock. I don't think we need a CQ. It was just a missing declaration, dependency was already installed via other packages.

Yes correct, it was initially added as a dep to @theia/metrics (the same version).
I was just waiting to merge in case others wanted a chance to review.

@vince-fugnitto vince-fugnitto merged commit c0302aa into eclipse-theia:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency for core package
3 participants