Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special output URI characters gracefully. #8046

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

Output URI handles special characters when converting channel name to URI and vice-versa.

How to test

You can see the renamed sample output channel.

Review checklist

Reminder for reviewers

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@vince-fugnitto vince-fugnitto added the output issues related to the output label Jun 18, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and the tests successfully pass.
I was able to see the sample output channel still working correctly.

@kittaakos
Copy link
Contributor Author

Thanks a lot for the quick review, @vince-fugnitto 👍

@kittaakos kittaakos merged commit dc5b9e1 into master Jun 18, 2020
@kittaakos kittaakos deleted the fix-output-uri branch June 18, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output issues related to the output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants