vsx-registry: fix the 'licenseUrl' link

[vince-fugnitto]

What it does

Fixes: #8094

The following pull-request fixes the licenseUrl link when attempting to open an extension's license from the vsx-editor.
Previously, the url was incorrect as it would refer to the local hosted path. If the data is available, use it directly to open the link.

How to test

1. open the 'extensions-view'
2. perform the same test for a builtin, installed and search result extension:
   • open the extension's info (header & readme), click the license link and verify the link works correctly

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[kittaakos]

Nice, I have tried it with the electron example, and I could open the license in my OS browser 👍
When I open the license for this extension
,
it opens the following URL: https://open-vsx.org/api/vscode/xml/1.46.1/file/LICENSE-vscode.txt
I do not understand the version difference between the VS Code extension and the link.

[vince-fugnitto]

I do not understand the version difference between the VS Code extension and the link.

@kittaakos thank you for the review! Without the changes proposed in #8063, the API call to open-vsx will always return the newest (latest) version which is why you see an updated version present in the link. The same is true about other information such as the rating, readme, etc.

[kittaakos]

he API call to open-vsx will always return the newest (latest) version which is why you see an updated version present in the link

👍 Follow-up: #8097

[kittaakos]

I have verified it locally with the electron example; I could open the license for the built-ins in my OS browser. 👍

[lmcbout]

LGTM
Tested on Ubuntu 18.04 with Chrome.
Thanks @vince-fugnitto