Add indent guidelines to all trees #8173

kaiyue0329 · 2020-07-14T20:05:02Z

What it does

Fixes #6586

Add preference to set 'workbench.tree.renderIndentGuides' to 'onHover' (default), 'none' or 'always'
When nodes are selected, indent guidelines are rendered for all the sibling nodes
When parent node is selected, indent guidelines are rendered for all the child nodes
When hovering over a tree, indent guidelines are displayed for all expanded nodes
Selecting multiple nodes works in a similar fashion

How to test

Set the workspace preference to 'onHover', 'none', 'always' and the rendering of the indent guidelines should change accordingly.
In different locations in Theia where the tree is being used (for example, in navigator, search in workspace, outline, problems-view and scm (list mode and tree mode)), select one/more nodes to test if the indent guidelines are rendered correctly.

Review checklist

as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

kaiyue0329 · 2020-07-14T20:10:16Z

The previous indent guidelines PR was closed due to the fork being deleted. Please refer to that PR for previous comments/discussion.

packages/core/src/browser/tree/tree-widget.tsx

packages/scm/src/browser/scm-tree-widget.tsx

packages/filesystem/src/browser/file-tree/file-tree-widget.tsx

packages/core/src/browser/common-frontend-contribution.ts

packages/core/src/browser/style/tree.css

packages/scm/src/browser/scm-tree-widget.tsx

packages/core/src/browser/tree/tree-widget.tsx

kaiyue0329 · 2020-07-27T21:53:34Z

@akosyakov This PR is ready for another view. I was wondering if you could take a look when you have a minute.

packages/core/src/browser/common-frontend-contribution.ts

packages/core/src/browser/tree/tree-widget.tsx

packages/core/src/browser/source-tree/source-tree-widget.tsx

packages/scm/src/browser/scm-tree-widget.tsx

packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx

packages/core/src/browser/tree/tree-widget.tsx

- Add preference to set 'workbench.tree.renderIndentGuides' to 'onHover' (default), 'none' or 'always' - When nodes are selected, indent guidelines are rendered for all the sibling nodes - When parent node is selected, indent guidelines are rendered for all the child nodes - When hovering over a tree, indent guidelines are displayed for all expanded nodes - Selecting multiple nodes works in a similar fashion Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>

akosyakov · 2020-08-04T09:53:15Z

minimal/backward compatible change: #8298 @kaiyue0329 I've added you as a co-author.

akosyakov · 2020-08-05T04:08:26Z

Superseded by #8298

vince-fugnitto added navigator issues related to the navigator/explorer scm issues related to the source control manager tree issues related to the tree (ex: tree widget) labels Jul 15, 2020

akosyakov self-requested a review July 15, 2020 09:31