Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIW]: Run search on input change #8229

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[SIW]: Run search on input change #8229

merged 1 commit into from
Jul 29, 2020

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Jul 23, 2020 •
edited
Loading

What it does

Fixes: #7346

Runs a search query only when there is a change in the input field

SIW

Signed-off-by: Anas Shahid muhammad.shahid@ericsson.com

How to test

  1. Search for a string in the workspace
  2. Press left or right arrow key to see if the search is re-running
  3. Try to toggle search options (like match case) to see if the search is successfully running again
  4. Press ENTER without changing the input, it should trigger a search.

Review checklist

Reminder for reviewers

@Anasshahidd21 Anasshahidd21 changed the title [SIW[: Run search on input change [SIW]: Run search on input change Jul 23, 2020
@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Jul 23, 2020
vince-fugnitto
vince-fugnitto approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well 👍

  • we perform a search if the search term is updated.
  • we always perform a search when the end-user triggers the enter key.
  • we do not perform a search if the search term is not updated

@akosyakov akosyakov requested a review from kittaakos July 24, 2020 04:45
[SIW]: Run search on input change
77f9b3a 
Fixes: eclipse-theia#7346

Runs a search query only when there is a change in the input field

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
kaiyue0329
kaiyue0329 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@kaiyue0329 kaiyue0329 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well 👍 . I confirmed that 1/search is not triggered if the search term is not updated, 2/search is triggered if the end-user pressed the enter key.

@Anasshahidd21
Copy link
Contributor Author

@kittaakos can you review if it's working for you?

kittaakos
kittaakos approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. Thank you!

@vince-fugnitto
Copy link
Member

I'll merge tomorrow if there are no objections 🚀

@vince-fugnitto vince-fugnitto merged commit 77fa067 into eclipse-theia:master Jul 29, 2020
@vince-fugnitto vince-fugnitto deleted the SIWInput branch July 29, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@kaiyue0329 kaiyue0329 kaiyue0329 approved these changes

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIW] The search should not run when input does not change
4 participants
@Anasshahidd21 @vince-fugnitto @kittaakos @kaiyue0329