Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapse-all command for SCM tree mode #8247

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add collapse-all command for SCM tree mode #8247

merged 1 commit into from
Aug 12, 2020

Conversation

kaiyue0329
Copy link
Contributor

@kaiyue0329 kaiyue0329 commented Jul 27, 2020

What it does

Fix: #8124

The following pull-request introduces a collapse-all toolbar item and command for the SCM when the view-mode is set to tree.

Tree Mode List Mode
Screen Shot 2020-07-27 at 8 35 56 PM Screen Shot 2020-07-27 at 8 38 05 PM

How to test

  1. start the application, make changes to the workspace and open the 'scm' view
  2. using the toolbar item to change the view mode, verify that:
    • list: the collapse-all item is not visible, and the command is not available using F1 > SCM: Collapse All
    • tree: the collapse-all item is visible, the command is available
  3. verify that the collapse-all command successfully collapses the nodes of the tree

Review checklist

Reminder for reviewers

Signed-off-by: Kaiyue Pan kaiyuepan@gmail.com

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager labels Jul 27, 2020
@kaiyue0329 kaiyue0329 marked this pull request as draft August 3, 2020 17:29
@kaiyue0329 kaiyue0329 marked this pull request as ready for review August 3, 2020 19:40
@kaiyue0329 kaiyue0329 requested a review from akosyakov August 3, 2020 19:40
@kaiyue0329 kaiyue0329 marked this pull request as draft August 4, 2020 17:17
@kaiyue0329 kaiyue0329 marked this pull request as ready for review August 5, 2020 03:04
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work very well! 👍

Uncollapsed:

Screen Shot 2020-08-05 at 7 41 38 PM

Collapsed:

Screen Shot 2020-08-05 at 7 42 40 PM

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes again and they work very well 👍

@kaiyue0329 kaiyue0329 marked this pull request as draft August 8, 2020 00:36
@kaiyue0329 kaiyue0329 marked this pull request as ready for review August 8, 2020 01:13
- Add `collapseAll` command for the SCM tree mode in `SCM toolbar` and `command palette`
- The command is not available for SCM flat mode

Signed-off-by: Kaiyue Pan <kaiyuepan@gmail.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes work well 👍

@kaiyue0329 kaiyue0329 requested a review from akosyakov August 12, 2020 05:48
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks good, please merge

@akosyakov
Copy link
Member

akosyakov commented Aug 12, 2020

@marcdumais-work @vince-fugnitto Maybe it is time to nominate Eclipse committers? I've seen continuous contributions like from 3-5 Ericsson collaborators.

@vince-fugnitto vince-fugnitto merged commit 7092725 into eclipse-theia:master Aug 12, 2020
@vince-fugnitto vince-fugnitto deleted the kaiyue/scm-collapse branch August 12, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support collapse all for SCM tree mode
3 participants