-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapse-all command for SCM tree mode #8247
Add collapse-all command for SCM tree mode #8247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the changes again and they work very well 👍
- Add `collapseAll` command for the SCM tree mode in `SCM toolbar` and `command palette` - The command is not available for SCM flat mode Signed-off-by: Kaiyue Pan <kaiyuepan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes work well 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise looks good, please merge
@marcdumais-work @vince-fugnitto Maybe it is time to nominate Eclipse committers? I've seen continuous contributions like from 3-5 Ericsson collaborators. |
What it does
Fix: #8124
The following pull-request introduces a collapse-all toolbar item and command for the
SCM
when theview-mode
is set totree
.How to test
list
: the collapse-all item is not visible, and the command is not available using F1 >SCM: Collapse All
tree
: the collapse-all item is visible, the command is availablecollapse-all
command successfully collapses the nodes of the treeReview checklist
Reminder for reviewers
Signed-off-by: Kaiyue Pan kaiyuepan@gmail.com