Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user storage regressions #8313

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • Start theia app and remove .theia in user home. Try to open keymaps and user settings.
  • Try to modify keymaps and check that changes are reflected.
  • Try to open settings file for different scopes, i.e. user, workspace, folder as a workspace and workspace folder.

Review checklist

Reminder for reviewers

Otherwise `FileService` fails to create the user directory.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added preferences issues related to preferences keybindings issues related to keybindings user storage issues related to user storage labels Aug 5, 2020
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the akosyakov/bug-error-thrown-when-8302 branch from a1c9e28 to 1c2b803 Compare August 5, 2020 14:25
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified and the regression works successfully! 👍

I verified the following (removing the ~/.theia before each test):

  • changing themes works correctly (the settings.json is successfully created)
  • opening the keymaps.json works successfully (the file is created if it does not exist)
  • modifying the keymaps.json through the UI works successfully again

*/
getConfigUri(resourceUri?: string): URI | undefined {
return undefined;
}

/**
* Returns undefined if there is config URI at all for the given resource URI.
Copy link
Member Author

@akosyakov akosyakov Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no

@akosyakov akosyakov merged commit 8d8406d into master Aug 6, 2020
@akosyakov akosyakov deleted the akosyakov/bug-error-thrown-when-8302 branch August 6, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings preferences issues related to preferences user storage issues related to user storage
Projects
None yet
2 participants