[explorer]: Badge count for dirty editors #8316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The changes work correctly:
- the number of dirty editors is correctly displayed
- the number of dirty editors are updated when the dirty state is changed, editors are closed
- the display works with
autoSaveon with a delay
I understand that NavigatorTabBarDecorator had to implement FrontendApplicationContribution since ApplicationShell could not be injected and used.
vince-fugnitto
added
badge
Anasshahidd21
force-pushed
the
dirtyEditors
branch
from
ecdda15 to
f23d916
Compare
akosyakov
reviewed
Aug 6, 2020
akosyakov
reviewed
Aug 6, 2020
akosyakov
reviewed
Aug 6, 2020
akosyakov
reviewed
Aug 6, 2020
akosyakov
reviewed
Aug 6, 2020
Anasshahidd21
force-pushed
the
dirtyEditors
branch
3 times, most recently
from
19b7f5a to
f20602b
Compare
akosyakov
reviewed
Aug 10, 2020
|
|
||
| protected readonly emitter = new Emitter<void>(); | ||
| private readonly toDispose = new DisposableCollection(); | ||
| private readonly toDisposeOnDirtyChanged = new Map<Widget, Disposable>(); |
There was a problem hiding this comment.
please don't hold a reference to a widget, but its id
Fixes: eclipse-theia#8296 Adds a badge count for dirty editors on the explorer tab icon. Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21
force-pushed
the
dirtyEditors
branch
from
f20602b to
35f25a9
Compare
|
@vince-fugnitto could you test and merge please? |
vince-fugnitto
approved these changes
Aug 10, 2020
|
@Anasshahidd21, how can I disable this feature without code modifications? Is there a preference for this? |
@kittaakos, in the current state of main, it is only possible to disable this feature with code modifications and not by any preference. |
|
Thank you! Here is the follow-up: #8709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8296
Adds a badge count for dirty editors on the explorer tab icon.
Signed-off-by: Anas Shahid muhammad.shahid@ericsson.com
How to test
Review checklist
Reminder for reviewers