Convert stylesheet.innerHTML to stylesheet.innerText #8397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers will interpret this the same but this protects against attacks such as: Change-Id: I34062ad3562a1791ec4ea5a404acf8f459cdcef9 https: //www.netsparker.com/blog/web-security/private-data-stolen-exploiting-css-injection/ Signed-off-by: LukeWood <lukewoodcs@gmail.com>
vince-fugnitto
added
plug-in system
vince-fugnitto
approved these changes
Aug 17, 2020
|
I'll merge tomorrow if there are no objections 👍 |
|
Cool - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers will interpret this the same but this protects
against attacks such as:
https://www.netsparker.com/blog/web-security/private-data-stolen-exploiting-css-injection/
Change-Id: I34062ad3562a1791ec4ea5a404acf8f459cdcef9
Signed-off-by: LukeWood lukewoodcs@gmail.com
What it does
Removes an XSS Sinks from Theia.
How to test
Should already be tested in unit tests
Review checklist
Reminder for reviewers