Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIW]: Exclude ignored files from search #8406

Closed
wants to merge 1 commit into from
Closed

[SIW]: Exclude ignored files from search #8406

wants to merge 1 commit into from

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Aug 19, 2020 •
edited by vince-fugnitto
Loading

What it does

Fixes: #7273

The pull-request includes the following changes:

  • adds support for the search.exclude preference.
  • adjusts the search-in-workspace to respect the preference when searching (both files.exclude and search.exclude).

How to test

  • verify that searching through the search-in-workspace (siw) works correctly.
  • verify that the siw respects the truthy files.exclude preference (ex: **/*.git does not yield results).
  • verify that the siw respects the truthy search.exclude preference.
  • verify that the search.exclude preference can override the default files.exclude preference values.
  • verify that the exclude input works correctly.
  • verify that the newly added tests for exclude pass successfully.

Review checklist

Reminder for reviewers

Signed-off-by: Anas Shahid muhammad.shahid@ericsson.com

@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Aug 19, 2020
@Anasshahidd21 Anasshahidd21 force-pushed the SIWIgnoredFiles branch 4 times, most recently from b12418b to 1624018 Compare August 20, 2020 14:38
@Anasshahidd21 Anasshahidd21 marked this pull request as draft August 20, 2020 14:38
@Anasshahidd21 Anasshahidd21 marked this pull request as ready for review August 20, 2020 15:08
@Anasshahidd21
Copy link
Contributor Author

@vince-fugnitto thank you for your review and also for helping me write additional tests. The PR is ready for another round of review.

@Anasshahidd21 Anasshahidd21 force-pushed the SIWIgnoredFiles branch 2 times, most recently from 86302db to 8bdddb1 Compare August 22, 2020 01:13
@akosyakov
Copy link
Member

Is it aligned with VS Code settings schemas?

@vince-fugnitto
siw: respect exclude preference when searching
03d322c 
Fixes: eclipse-theia#7273

The commit includes the following updates:
- adds the preference `search.exclude`
- adjusts the search-in-workspace to respect both the `files.exclude` and `search.exclude` preferences when searching.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@vince-fugnitto
Copy link
Member

Closing in favor of: #8433 which has the minimal changes.

The search.exclude preference can be added at a later time, it should not exist in siw since it is ultimately used in different places such as @theia/file-search as well.

@madmini madmini mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto left review comments

@akosyakov akosyakov akosyakov left review comments

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search-in-workspace: does not respect 'files.exclude'
3 participants
@Anasshahidd21 @akosyakov @vince-fugnitto