-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow debug widgets to get updated when not visible #8645
Allow debug widgets to get updated when not visible #8645
Conversation
VS Code does it differently. When the debug session is over and the debug view was not active, Code leaves the trees untouched. The trees are cleaned up only when the debug view is activated again and there is not active debug session. See the screencast Why do not we do the same? If not necessary, let's not introduce another property on the tree-widget just because you want to work around something. (Especially, you can customize this behavior in your extension.) Can we handle this issue with |
|
Actually I've noticed that this issue is also present in vanilla Theia. All it takes to see it is too start a debug session, switch the active panel and then stop the active debug session by using
@kittaakos I think this is a brilliant idea. |
ae918b9
to
b33bc25
Compare
Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
b33bc25
to
c5adb9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@federicobozzini the changes work very well for me and provide a much better debugging experience, similarly to vscode:
- open a
*spec.ts
file. - start debugging with the
run mocha test
configuration. - open the
explorer
. - return to the
debug view
once the session has ended. - the
debug view
is properly updated, while on master it is not.
@federicobozzini do you need help merging? |
@vince-fugnitto Yes, please. I don't have the permissions to merge this PR. |
What it does
This adds a property
alwaysUpdate
toTreeWidget
that can be used to force a widget to update even when not visible or attached. This property is used by the Widgets showing debug information to get rendered even when not visible.Fixes: #8639.
How to test
The easiest way to test this, would be to switch the active panel right after a debug session is terminated. This would normally prevent the debug information to get cleared, because of debug widgets not being visible. With this PR the debug widgets are correctly cleared when the debug session is terminated.
Review checklist
Reminder for reviewers