Changed srcElement to target in mini browser #8663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toma Puljak toma.puljak@hotmail.com
What it does
The following pull-request updates the deprecated
scrElement
event prop withtarget
for the mini-browser package when handling the ENTER key to reload the page and update the content to the new location. The change is suggested by mozilla documentation.How to test
In order to test the changes, you can use the
Open URL
command with some minor tweaks. Since theOpen URL
command uses areadonly
input, it will need to be updated toshow
so the handler can successfully process the ENTER key code.show
:theia/packages/mini-browser/src/browser/mini-browser-open-handler.ts
Line 282 in deccec6
npx run build @theia/mini-browser
npx run build @theia/example-electron
)Open URL
commandREAMDE.md
)Review checklist
Reminder for reviewers