Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API doc for 'BackendApplicationContribution' #8686

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Oct 29, 2020

Closes #8685

Signed-off-by: Stefan Dirix sdirix@eclipsesource.com
Contributed on behalf of STMicroelectronics

What it does

Add API doc for BackendApplicationContribution

How to test

Check whether API Doc is correct and run yarn run lint to check for formatting errors.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Oct 29, 2020
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, LGTM otherwise :)

packages/core/src/node/backend-application.ts Outdated Show resolved Hide resolved
packages/core/src/node/backend-application.ts Outdated Show resolved Hide resolved
@sdirix sdirix force-pushed the backendcontribution-documentation branch from 069e60a to 0a4c5ae Compare October 30, 2020 07:17
@sdirix
Copy link
Member Author

sdirix commented Oct 30, 2020

@marechal-p Thanks for the quick review 👍. I adressed your comments. Please let me know whether you would like to see further changes :)

Signed-off-by: Stefan Dirix <sdirix@eclipsesource.com>
Contributed on behalf of STMicroelectronics
@sdirix sdirix force-pushed the backendcontribution-documentation branch from 0a4c5ae to 4936090 Compare October 30, 2020 07:19
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paul-marechal paul-marechal merged commit f906ee0 into eclipse-theia:master Nov 4, 2020
@paul-marechal paul-marechal added this to the 1.8.0 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API documentation for 'BackendApplicationContribution'
3 participants