Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for TreeDecorator & TreeDecoratorService #8698

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Nov 2, 2020

Fixes #8696

  • Refine documentation for TreeDecorator
  • Refine documentation for TreeDecoratorService
    Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
    Contributed on behalf of STMicroelectronics

What it does

Add/refines documentation for TreeDecorator.

How to test

Documentation changes only

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall content looks good 👍

packages/core/src/browser/tree/tree-decorator.ts Outdated Show resolved Hide resolved
packages/core/src/browser/tree/tree-decorator.ts Outdated Show resolved Hide resolved
@vince-fugnitto vince-fugnitto added core issues related to the core of the application documentation issues related to documentation labels Nov 2, 2020
@tortmayr tortmayr force-pushed the tree branch 2 times, most recently from dacdcf2 to 3edc6e4 Compare November 4, 2020 11:08
@tortmayr
Copy link
Contributor Author

tortmayr commented Nov 4, 2020

Thanks for the fast review. I applied your feedback suggestions.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍
Please be sure to squash and include a proper sign-off (currently failing the eca check) so we can merge.

Fixes eclipse-theia#8696
- Refine documentation for `TreeDecorator`
- Refine documentation for `TreeDecoratorService`
Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/refine documentation for TreeDecorator
2 participants