Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] WorkspaceFrontendContribution is not binded to FrontendApplication #8734

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

DoroNahari
Copy link
Contributor

What it does

Bind WorkspaceFrontendContribution to FrontendApplication.
Today they are not binded and this causes the workspaceFrontendContribution.configure() to not being called.
This make the statusBar color blue (instead of purple) even if workspace is not opened.

How to test

Open Theia in browser.
Open browser dev tools.
In the dev tools, open workspace-frontend-contribution.ts file and put breakpoint inside the configure method.

Before:
configure() isn't being called. the debugger doesn't stop inside configure()
After:
configure() is called. the debugger stop inside configure()

Another way:
Open theia without opened workspace or click File -> Close Workspace
Before:
The status bar is blue instead of purple.
After:
The status bar is purple.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added bug bugs found in the application workspace issues related to the workspace labels Nov 10, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoroNahari the changes work well for me, thank you for taking care of it 👍
Please be sure to update the pull-request to include a sign-of (currently failing) so we can merge.

Signed-off-by: Doron Nahari <doron.nahari@sap.com>
@DoroNahari
Copy link
Contributor Author

Please be sure to update the pull-request to include a sign-of (currently failing) so we can merge.

Done. you can merge now. Thank you @vince-fugnitto

@vince-fugnitto vince-fugnitto merged commit 1e60351 into eclipse-theia:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application workspace issues related to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants