-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): use GitHub Actions for CI/CD #8775
Conversation
a25807f
to
eed9638
Compare
a80a029
to
33b181d
Compare
f514a71
to
bf06d64
Compare
Replace `.travis.yml` with GitHub Actions. Splitting scripts was needed to correctly run in CI: - `yarn` now only install deps and builds example apps. - `yarn lint` lints our TypeScript sources. `THEIA_SKIP_BUILD=1` can be enabled to only install deps when doing `yarn`.
bf06d64
to
51803d6
Compare
@kittaakos just a heads up that I think this PR is ready for review. What's done:
What's missing:
I think the missing parts can be added later, but feel free to push on this branch to add things you think should be there. |
Thank you for preparing it, @marechal-p. There are a few things I do not really like: such as unnecessary configs, changed npm scripts, hacks, and the publish build does not wait. Here is my proposal. There is one thing I do not understand, the macOS build fails for some reason.
Here is the build without the macOS image, and here is with macOS. I also updated the issue for this PR: we do the codec thingy after the |
There is something odd with the Here are the outputs from Linux and macOS: macOS:
Linux:
Windows:
|
Here is an alternative solution: #8780 |
Yes and since I did not have access to a mac I avoided this issue by not using
It happens on |
Closing in favor of #8780 |
Replace
.travis.yml
with GitHub Actions.Splitting scripts was needed to correctly run in CI:
yarn
now only install deps and builds example apps.yarn lint
lints our TypeScript sources.THEIA_SKIP_BUILD=1
can be enabled to only install deps when doingyarn
.Notes:
I skipped the flakiest tests, but it seems like some are still causing trouble. Feel free to restart the jobs.