Correct type guard for FileStat.is #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westbury
force-pushed
the
file-stat-type
branch
from
f7ab84f to
48719d0
Compare
Signed-off-by: Nigel Westbury <nigelipse@miegel.org>
|
I confirm that the current code spoils code intelligence about a successful |
colin-grant-work
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is a fix to a copy-and-paste error. A new test was created a few months back in Theia 1.5 for FileStat. However the type guard was left at BaseStat, meaning one can't access isDirectory etc. after testing for a FileStat.
How to test
This cannot be tested without making modifications to the code.
Although FileStat.is is used a few times in the Theia codebase, in most cases the code does not access FileStat properties afterwards. In the cases where the FileStat property isDirectory is used, the original type is URI | URIIconReference | FileStat, typescript being smart enough to determine that if the type is BaseStat then it must be FileStat.
Review checklist
Reminder for reviewers