Quick File Open: Support for Search Queries with Whitespaces

[seantan22]

What it does

Fixes #8747

• Allows whitespaces to be included in a quick file open search query.
• Adds support for whitespaces in the scoring of file search results.
• Adds tests for whitespace queries (considers fuzzy matching and search
  term order).

How to test

1. ctrl + p to quick file open
2. Search for a file with a query that includes whitespaces (eg. readme core)
3. Observe that whitespaces do not affect the search results

Alternatively, run @theia/file-search tests.

Before Changes:

After Changes:

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: seantan22 sean.a.tan@ericsson.com

[vince-fugnitto]

The changes work very well for me, and the results are much better than master.
I am now able to search with whitespaces, and the scoring has been properly updated to take whitespaces into consideration and prioritize exact matches.

[vince-fugnitto]

@colin-grant-work I found an issue with the previous approach with fuzzy.match that has been addressed in the latest changes.
Would you mind re-reviewing and if you're happy with the changes please feel free to merge them.

[DucNgn]

LGTM 👍
I reviewed and tested the changes on my side, confirmed that the feature is working correctly. Nice to be able to search with whitespaces!

[colin-grant-work]

So the basic functionality is working, but there is one defect when searching with whitespace. With no whitespace, we get highlighting in the results:

with whitespace, we get no highlighting:

It's still an improvement (I'd rather see the results with no highlighting than have to constantly remember not to put spaces in my queries), but it would be great to get the highlighting functionality working, as well.

[vince-fugnitto]

So the basic functionality is working, but there is one defect when searching with whitespace. With no whitespace, we get highlighting in the results:

The highlighting is a known issue #4548 and would require some extensive changes on how we compute the matching (#5638 (comment)). For that reason I'm fine with omitting it from the pull-request as it is out of scope.

[colin-grant-work]

The highlighting is a known issue #4548 and would require some extensive changes on how we compute the matching (#5638 (comment)). For that reason I'm fine with omitting it from the pull-request as it is out of scope.

Sounds good. Having touched the highlighting code lightly, I agree it would be a huge lift for this PR. My approval is reaffirmed.

[vince-fugnitto]

I'll merge tomorrow if there are no objections :)