Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7103: API for removing toolbar item. #9044

Merged
merged 2 commits into from
Mar 4, 2021
Merged

GH-7103: API for removing toolbar item. #9044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c52c80c
GH-7103: API for removing toolbar item.
Feb 9, 2021
dd6d048
Fixed flawed `registerToolbarItems` for the Output
Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/core/src/browser/shell/tab-bar-toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,4 +455,11 @@ export class TabBarToolbarRegistry implements FrontendApplicationContribution {
return result;
}

unregisterItem(itemOrId: TabBarToolbarItem | ReactTabBarToolbarItem | string): void {
const id = typeof itemOrId === 'string' ? itemOrId : itemOrId.id;
if (this.items.delete(id)) {
this.fireOnDidChange();
}
}

}
2 changes: 1 addition & 1 deletion packages/output/src/browser/output-toolbar-contribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class OutputToolbarContribution implements TabBarToolbarContribution {
this.outputChannelManager.onChannelWasHidden(fireChannelsChanged);
}

async registerToolbarItems(toolbarRegistry: TabBarToolbarRegistry): Promise<void> {
registerToolbarItems(toolbarRegistry: TabBarToolbarRegistry): void {
toolbarRegistry.registerItem({
id: 'channels',
render: () => this.renderChannelSelector(),
Expand Down