Fix bind multiple Contribution using for of instead foreach

[hogod]

Fix to use for of instead Array.foreach when bind multiple Contribution in frontend module in common

Signed-off-by: Byeongho Jung hobeoung2@gmail.com

What it does

When bind multiple contribution someone use for of (ex. monaco-frontend-module, terminal-frontend-module, etc) and others use foreach (ex. frontend-application-module, editor-frontend-module). So, I fix them to use for of in common. Cause this logic bind designated Contribution rather than processing Array element, I think it is natural to use for of.

How to test

I Just check working well and check correct parameter passed to bind() using logging.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[hogod]

I test on MacOS and Ubuntu 20.04 before pull request, and try to find ubuntu build problem now.

[hogod]

I Cannot Reproduce in my ubuntu 18.04 docker environment either.
But, I Found Same Error in #9100, #9081, Can I get the reason about this problem or Clue to Analysis this Problem?

[vince-fugnitto]

I Cannot Reproduce in my ubuntu 18.04 docker environment either.
But, I Found Same Error in #9100, #9081, Can I get the reason about this problem or Clue to Analysis this Problem?

@hogod those other pull-requests likely fail since they are not based on the latest master which has a fix for the intermittent failures when testing the browser application (api-tests).

[vince-fugnitto]

@hogod thank you for the contribution, was there a specific reason the changes were proposed?
I'm not sure the updates are necessary or add much value, nor is there a fixed convention (as described in the coding guidelines) for using for of instead of forEach when binding.

[hogod]

My purpose is to achieve same operation, same code for pretty.

Previously, two styles were mixed.

for (const identifier of [CommandContribution, KeybindingContribution, QuickOpenContribution]) { bind(identifier).toService(EditorContribution); }

[CommandContribution, KeybindingContribution, MenuContribution].forEach(serviceIdentifier => bind(serviceIdentifier).toService(QuickCommandFrontendContribution) );

And I agree with your opinion that it is not really necessary or add much value.

Thanks for the review!

[vince-fugnitto]

...same code for pretty.
And I agree with your opinion that it is not really necessary or add much value.

Since we agree that the changes are not necessary, do not add value and are only for "pretty", should we close the pull-request?
There is no eslint rules, or guidelines on enforcing the convention so there is no guarantee that new contributions will not deviate.

[hogod]

Okay, I'll close this pull request.