-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register 'workbench.action.files.openFileFolder' VS Code command #9213
Conversation
51caf1e
to
f1b938a
Compare
@vzhukovs |
packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
f1b938a
to
b01fa23
Compare
@RomanNikitenko, checked test extension on Browser Example, Electron Example and VS Code.
openFileFolder-theia.mp4
openFileFolder-electron.mp4
openFileFolder-vscode.mp4Let me know if there should be an additional use cases that need to be checked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, the open
dialog that supports files and folders should only be available in the browser, and macos on electron 👍
Thank you everyone for the review and testing! |
What it does
Add support for
workbench.action.files.openFileFolder
built-in command: #8750The command should be available for running for:
Theia
dialog supports the featureHow to test
My test extension can be used for testing:
theia/plugins
folder.Theia
and open a workspace folder.F1
=> runTest 'workbench.action.files.openFileFolder'
a dialog should be displayed which allows to open a file or a directory
Review checklist
Reminder for reviewers
Signed-off-by: Roman Nikitenko rnikiten@redhat.com