Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed _preview editor from references widget. #9245

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

kittaakos
Copy link
Contributor

What it does

With the new internal API, one can have better typing when customizing the peek editor from monaco. We already have Monaco customization in Theia:

toDispose.push(this.installQuickOpenService(editor));
toDispose.push(this.installReferencesController(editor));

this PR helps to provide other monaco customizations.

How to test

Review checklist

Reminder for reviewers

With the new internal API, one can have better typing when customizing
the peek editor from `monaco`.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vince-fugnitto vince-fugnitto added extensibility issues to simplify ability to extend Theia monaco issues related to monaco labels Mar 24, 2021
@kittaakos kittaakos merged commit 3782e9b into eclipse-theia:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants