Revert task types updates #9373
Conversation
|
I think I have a better fix coming. Give me a couple of hours. |
There was a problem hiding this comment.
I tested the changes and can confirm that they fix the following issues for me:
- Task type is not displayed for detected tasks #9341
- Configuring tasks are broken #9365
- task: unable to run provided tasks #9366
- resolve problemMatchers for tasks executed by vscode.tasks.executeTask api call #9207 (review)
Let's wait for the PR from @tsmaeder.
| @@ -1911,18 +1911,21 @@ export class Task { | |||
| private updateDefinitionBasedOnExecution(): void { | |||
| if (this.taskExecution instanceof ProcessExecution) { | |||
| Object.assign(this.taskDefinition, { | |||
| type: 'process', | |||
There was a problem hiding this comment.
I don't think we should ever update the type field: in Eclipse Che, we register a TaskRunnerfor the task type 'che'. Once the type field is overwritten, we can't get it back.
There was a problem hiding this comment.
This update has been there for two years before the introduction of customExecution,
I am trying to understand how this has not caused problems for 'che' then ?
There was a problem hiding this comment.
Thomas, I think @alvsan09 is right: I provided these changes 2 years ago, please see
There was a problem hiding this comment.
|
Replaced by: #9377 |
What it does
Reverts commits affecting the use of task type
The PR #9189 merged 5 commits to support the Tasks customExecution API,
one of the commits ("Fixed task type is modified") impacted how the task type is used in multiple areas of the task
system, impacting the functionality to configure tasks, running tasks, etc.
There are a couple of other commits trying to fix the broken scenarios which cascaded to other problems.
This PR brings back the functionality before the commit mentioned above.
How to test
NOTE: Gradle tasks are not expected to be visible in the task view since that's the scenario which was addressed by the
reverted commit (a proper solution shall be discussed).
Review checklist
Reminder for reviewers