Explicitly mark UnsafeWidgetUtilities #9967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
Aug 26, 2021
|
Would you please re-base the change as there is a conflict with |
colin-grant-work
force-pushed
the
bugfix/false-attachments
branch
from
561c6c5 to
ed277d5
Compare
|
@alvsan09, thanks for the pointer. I've rebased. |
Create a new namespace for non-error-checked versions of Phosphor utilities, replaces existing code blocks, and applies the new utilities to cases that were throwing errors. As the name implies, these utilities are unsafe because they violate the expectations of Phosphor widgets. We should investigate why we ever wrote code to do this in the first place, and fix it if possible. Signed-off-by: Colin Grant <colin.grant@ericsson.com>
colin-grant-work
force-pushed
the
bugfix/false-attachments
branch
from
ed277d5 to
d54c114
Compare
alvsan09
approved these changes
Aug 26, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Create a new namespace for non-error-checked versions of Phosphor utilities, replaces existing code blocks, and applies the new utilities to cases that were throwing errors. As the name implies, these utilities are unsafe because they violate the expectations of Phosphor widgets. We should investigate why we ever wrote code to do this in the first place, and fix it if possible. Signed-off-by: Colin Grant <colin.grant@ericsson.com>
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Create a new namespace for non-error-checked versions of Phosphor utilities, replaces existing code blocks, and applies the new utilities to cases that were throwing errors. As the name implies, these utilities are unsafe because they violate the expectations of Phosphor widgets. We should investigate why we ever wrote code to do this in the first place, and fix it if possible. Signed-off-by: Colin Grant <colin.grant@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9960 by working around it.
This PR creates a new namespace for non-error-checked versions of Phosphor
utilities, replaces existing code blocks, and applies the new
utilities to cases that were throwing errors.
As the name implies, these utilities are unsafe because they
violate the expectations of Phosphor widgets. We should investigate
why we ever wrote code to do this in the first place, and fix it
if possible.
How to test
ViewContainerPartswith toolbars.Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com