ms-vscode.js-debug no longer included #123
Comments
|
This extension is central to dog-fooding and included in VS Code out of the box. |
|
According to the logs when we published it seems that it was skipped. |
Hummm, It seems this extension and its companion were skipped, when generating the built-ins pack, because they were not found on openvsx. I do not know if it's a bug in our script or if there was a glitch with the server. |
We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding the mto the pack, to avoid issues installing the pack. For this case, we were generating a URL that had a trailing slash, which did not work: Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/ Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion Fixes eclipse-theia#123 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
|
I think I found a bug that explains the above. We can fix it now, so that these extensions will be part of the pack next time. |
We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding them to the pack, to avoid issues when resolving the pack(we do not check for a specifc version, because they may not follow vscode's versioning). It turns-out that For this case, we were generating a URL that had a trailing slash, which did not work: Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/ Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion P.S. also aligned version of `node-fetch` and its typings Fixes eclipse-theia#123 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding them to the pack, to avoid issues when resolving the pack(we do not check for a specific version, because they may not follow vscode's versioning). It turns-out that For this case, we were generating a URL that had a trailing slash, which did not work: Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/ Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion P.S. also aligned version of `node-fetch` and its typings Fixes eclipse-theia#123 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding them to the pack, to avoid issues when resolving the pack(we do not check for a specific version, because they may not follow vscode's versioning). It turns-out that For this case, we were generating a URL that had a trailing slash, which did not work: Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/ Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion P.S. also aligned version of `node-fetch` and its typings Fixes eclipse-theia#123 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding them to the pack, to avoid issues when resolving the pack(we do not check for a specific version, because they may not follow vscode's versioning). It turns-out that For this case, we were generating a URL that had a trailing slash, which did not work: Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/ Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion P.S. also aligned version of `node-fetch` and its typings Fixes #123 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
|
@tsmaeder we found and fixed the bug, that mistakenly excluded The good news is that Blueprint is unaffected (probably like most Theia apps out- there) - It's not yet using that version of the built-ins pack, currently using slightly older v1.77.0. The extensions, listed in a pack, are not versioned, and always resolve to the latest compatible version, according to stated extensions API version supported (the version of the pack does not play a role). This means that, using a relatively recent version of the pack, should be virtually just as good. The only downside I see is that any extension added or legitimately removed in 1.79.0 would not be if we used the previous version. I do not think that's a problem ATM, but if it is for someone, they can work-around the issue by strategically explicitly adding and/or excluding extensions, to fit their needs. Plan going forward: For Blueprint, wait until a new set of vscode built-ins is released before updating the built-ins pack it uses (currently v1.77.0) WDYT? |
The ms-vscode.js-debug extension that provides typescript/javascript debugging in VS Code is no longer included in the theia built-in extension pack in the latest version. It used to be included in the built-in extension pack.
The text was updated successfully, but these errors were encountered: