feat: log some ClassCastExceptions for better troubleshooting

eclipse-tm4e · May 22, 2024 · 9c58e16 · 9c58e16
1 parent b6ea4b4
commit 9c58e16
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/...lipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/grammar/raw/RawCaptures.java b/...lipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/grammar/raw/RawCaptures.java
@@ -9,15 +9,26 @@
  */
 package org.eclipse.tm4e.core.internal.grammar.raw;
 
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+
 import org.eclipse.tm4e.core.internal.parser.PropertySettable;
 
 final class RawCaptures extends PropertySettable.HashMap<IRawRule> implements IRawCaptures {
 
+	private static final Logger LOGGER = System.getLogger(RawCaptures.class.getName());
+
 	private static final long serialVersionUID = 1L;
 
 	@Override
 	public IRawRule getCapture(final String captureId) {
-		return get(captureId);
+		try {
+			return get(captureId);
+		} catch (final ClassCastException ex) {
+			// log ClassCastException with some context, to better troubleshoot issues like https://github.com/eclipse/tm4e/issues/754
+			LOGGER.log(Level.ERROR, "Unexpected ClassCastException in RawCaptures.getCapture(\"" + captureId + "\")", ex);
+			throw ex;
+		}
 	}
 
 	@Override

diff --git a/...pse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/grammar/raw/RawRepository.java b/...pse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/grammar/raw/RawRepository.java
@@ -11,13 +11,17 @@
  */
 package org.eclipse.tm4e.core.internal.grammar.raw;
 
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
 import java.util.NoSuchElementException;
 
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.tm4e.core.internal.parser.PropertySettable;
 
 public final class RawRepository extends PropertySettable.HashMap<IRawRule> implements IRawRepository {
 
+	private static final Logger LOGGER = System.getLogger(RawRepository.class.getName());
+
 	private static final long serialVersionUID = 1L;
 
 	public static final String DOLLAR_BASE = "$base";
@@ -35,7 +39,13 @@ private IRawRule getSafe(final String key) {
 	@Override
 	@Nullable
 	public IRawRule getRule(final String name) {
-		return get(name);
+		try {
+			return get(name);
+		} catch (final ClassCastException ex) {
+			// log ClassCastException with some context, to better troubleshoot issues like https://github.com/eclipse/tm4e/issues/754
+			LOGGER.log(Level.ERROR, "Unexpected ClassCastException in RawRepository.getRule(\"" + name + "\")", ex);
+			throw ex;
+		}
 	}
 
 	@Override