Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IMarkers for BUG,NOTE,FIXME,HACK,TODO,XXX comments #414

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Jun 10, 2022

This PR addresses #405.

Example:
markers

The markers are asynchronously updated via:
TMModel.TokenizerThread#revalidateTokens()
TMPresentationReconciler.InternalListener#modelTokensChanged()
MarkerUtils.updateTextMarkers()

@sebthom
Copy link
Member Author

sebthom commented Jun 10, 2022

@mickaelistria @akurtakov @angelozerr please give this a try if you have a chance

@sebthom sebthom force-pushed the patch-04 branch 2 times, most recently from c1797b3 to e755301 Compare June 10, 2022 18:27
@sebthom sebthom marked this pull request as ready for review June 10, 2022 18:27
@sebthom sebthom force-pushed the patch-04 branch 2 times, most recently from 1423c7e to 56bffa3 Compare June 10, 2022 19:03
@sebthom sebthom changed the title Create IMarkers for TODO,FIXME,HACK,XXX comments Create IMarkers for BUG,NOTE,FIXME,HACK,TODO,XXX comments Jun 10, 2022
@sebthom sebthom force-pushed the patch-04 branch 3 times, most recently from b795fc0 to a9bdebf Compare June 10, 2022 21:36
@mickaelistria mickaelistria merged commit fbe8606 into eclipse-tm4e:master Jun 13, 2022
@mickaelistria
Copy link
Contributor

Thanks!

@mickaelistria mickaelistria linked an issue Jun 13, 2022 that may be closed by this pull request
@sebthom sebthom deleted the patch-04 branch June 22, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO/FIXME comment markers
3 participants