Skip to content

Commit

Permalink
fix(dev): add file extension and refactor called method in gradle
Browse files Browse the repository at this point in the history
  • Loading branch information
pmoscode committed Nov 21, 2023
1 parent eef32c1 commit 6811a8b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/app-test-coverage-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
if: always()
with:
paths: |
${{ github.workspace }}/build/reports/xml/jacoco
${{ github.workspace }}/build/reports/xml/jacoco.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: 80
min-coverage-changed-files: 80
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/app-test-coverage-repo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Create Markdown from code coverage report
uses: danielpalme/ReportGenerator-GitHub-Action@5.1.25
with:
reports: reports/xml/jacoco
reports: reports/xml/jacoco.xml
targetdir: coveragereport
reporttypes: MarkdownSummaryGithub
sourcedirs: src/main/java
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ plugins {
group = "${groupName}"
version = "${applicationVersion}"
sourceCompatibility = JavaVersion.VERSION_17

// Fetch the environment variables GITHUB_USERNAME, GITHUB_TOKEN
// these can be set in <project_root>/.env
// or export GITHUB_USERNAME=...
Expand Down Expand Up @@ -221,12 +222,12 @@ jacocoTestReport {

reports {
xml.enabled true
xml.outputLocation = layout.buildDirectory.dir("${buildDir}/reports/xml/jacoco")
xml.outputLocation = file("./build/reports/xml/jacoco.xml")

csv.enabled false

html.enabled true
html.outputLocation = layout.buildDirectory.dir("${buildDir}/reports/html/jacoco")
html.outputLocation = file("./build/reports/html/jacoco")
}

afterEvaluate {
Expand All @@ -245,7 +246,6 @@ jacocoTestReport {
// docs: https://docs.gradle.org/current/userguide/jacoco_plugin.html#sec:configuring_the_jacoco_plugin
jacoco {
toolVersion = "${jacocoVersion}"

}


Expand Down

0 comments on commit 6811a8b

Please sign in to comment.