-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Azure Blob Provisioner extension #1536
Merged
paullatzelsperger
merged 9 commits into
eclipse-tractusx:main
from
paullatzelsperger:fix/az_s3_provision_extension
Sep 6, 2024
Merged
fix: add Azure Blob Provisioner extension #1536
paullatzelsperger
merged 9 commits into
eclipse-tractusx:main
from
paullatzelsperger:fix/az_s3_provision_extension
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
bug
Something isn't working
critical
All issues that will definitely be in the milestone they are planned for
labels
Sep 6, 2024
@rafaelmag110 FYI |
Quality Gate passedIssues Measures |
wolf4ood
approved these changes
Sep 6, 2024
paullatzelsperger
added a commit
to paullatzelsperger/tractusx-edc
that referenced
this pull request
Sep 6, 2024
* add dedicated cloud e2e test module * added test without container * add s3 provision and e2e test (wip) * backport/copy upstream AZ Blob Provisioner * add s3 destination credentials * fix lic header format * avoid NPE in the generator * DEPENDENCIES * re-enable FCC crawling in tests
paullatzelsperger
added a commit
that referenced
this pull request
Sep 16, 2024
* fix: add Azure Blob Provisioner extension (#1536) * add dedicated cloud e2e test module * added test without container * add s3 provision and e2e test (wip) * backport/copy upstream AZ Blob Provisioner * add s3 destination credentials * fix lic header format * avoid NPE in the generator * DEPENDENCIES * re-enable FCC crawling in tests * DEPENDENCIES * add documentation * add JSON annotations * fix tests
ndr-brt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* fix: add Azure Blob Provisioner extension (#1536) * add dedicated cloud e2e test module * added test without container * add s3 provision and e2e test (wip) * backport/copy upstream AZ Blob Provisioner * add s3 destination credentials * fix lic header format * avoid NPE in the generator * DEPENDENCIES * re-enable FCC crawling in tests * DEPENDENCIES * add documentation * add JSON annotations * fix tests * Remove Transfer DataPlane Signaling Dependencies redundancy. * Updated DEPENDENCIES. --------- Co-authored-by: Paul Latzelsperger <43503240+paullatzelsperger@users.noreply.github.com> Co-authored-by: Paul Latzelsperger <paul.latzelsperger@beardyinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR backports the upstream
provision-blob
extension that allows for creating blob containers and temporary SAS tokens.Also adds a End-To-End test for cloud transfers, because up until now, we only had tests that solely used the dataplane.
Note that the S3 Provisioner was not backported, because the are some inconsistencies with the endpoint override. For some SDK interactions, the endpoint override can be specified dynamically, for others it is based on a configuration value. That may not be usable in a practical environment.
Technically, this would have meant:
WHY
Allowing the creation of temporary SAS tokens when using Azure Blob Storage as data destination.
FURTHER NOTES
bugfix/0.7.5
branchedc-extensions/backport
directoryCloses # <-- insert Issue number if one exists