Fix possible NPE in AbstractApplication as seen in integration tests

eclipse-tycho · Nov 7, 2023 · 270938c · 270938c
1 parent 825bee3
commit 270938c
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/tycho-core/src/main/java/org/eclipse/tycho/p2tools/copiedfromp2/AbstractApplication.java b/tycho-core/src/main/java/org/eclipse/tycho/p2tools/copiedfromp2/AbstractApplication.java
@@ -277,11 +277,19 @@ public IArtifactRepository getCompositeArtifactRepository() {
     }
 
     public boolean hasArtifactSources() {
-        return ((ICompositeRepository<?>) getCompositeArtifactRepository()).getChildren().size() > 0;
+        IArtifactRepository repository = getCompositeArtifactRepository();
+        if (repository instanceof ICompositeRepository<?> composite) {
+            return composite.getChildren().size() > 0;
+        }
+        return false;
     }
 
     public boolean hasMetadataSources() {
-        return ((ICompositeRepository<?>) getCompositeMetadataRepository()).getChildren().size() > 0;
+        IMetadataRepository repository = getCompositeMetadataRepository();
+        if (repository instanceof ICompositeRepository<?> composite) {
+            return composite.getChildren().size() > 0;
+        }
+        return false;
     }
 
     public abstract IStatus run(IProgressMonitor monitor) throws ProvisionException;