Skip to content

Commit

Permalink
Make Tycho work behind https proxy
Browse files Browse the repository at this point in the history
If a proxy is specified with the https procotol in the settings.xml,
Tycho fails downloading artifacts from any URL that uses that proxy,
because it wrongly configures a SOCKS transport in such cases.

Fixes #1935, #2709, #2533.
  • Loading branch information
Bananeweizen committed Dec 24, 2023
1 parent 134f372 commit 9995887
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ private static Type convertType(String type) {
if (org.eclipse.aether.repository.Proxy.TYPE_HTTP.equalsIgnoreCase(type)) {
return Type.HTTP;
}
if (org.eclipse.aether.repository.Proxy.TYPE_HTTPS.equalsIgnoreCase(type)) {
return Type.HTTP;
}
return Type.SOCKS;
}

Expand Down

0 comments on commit 9995887

Please sign in to comment.