Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tycho should provide a WorkspaceReader #585

Closed
laeubi opened this issue Jan 29, 2022 · 1 comment
Closed

Tycho should provide a WorkspaceReader #585

laeubi opened this issue Jan 29, 2022 · 1 comment
Labels
future ideas Probabbly become relevant for Tycho in the future.
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Jan 29, 2022

Currently we inject maven dependencies into the maven model as "system-scoped" dependencies. System-Scope is deprecated and we only do it to prevent maven from trying to resolve those dependencies.

More maven-concentric would be, that we add the dependencies as "normal" dependencies and provide a WorkspaceReader that resolves these artifacts to the corresponding P2 data of the project.

Still there are some issues from the maven side before we really can do this see:

as currently there is no way to know what project actually requests the current dependency from the WorkspaceReader component and we would be required to register this as a core-extension using some nasty hacks to get our WorkspaceReader actually considered.

@laeubi laeubi added the future ideas Probabbly become relevant for Tycho in the future. label Jan 29, 2022
laeubi added a commit to laeubi/tycho that referenced this issue Jan 29, 2022
laeubi added a commit to laeubi/tycho that referenced this issue Jun 12, 2022
laeubi added a commit to laeubi/tycho that referenced this issue Jun 12, 2022
@laeubi
Copy link
Member Author

laeubi commented Jun 12, 2022

Just a minor issue: https://issues.apache.org/jira/browse/MNG-7496

@laeubi laeubi closed this as completed in a7101b7 Jun 12, 2022
@laeubi laeubi added this to the 3.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future ideas Probabbly become relevant for Tycho in the future.
Projects
None yet
Development

No branches or pull requests

1 participant