JGit packaging build fails with Tycho 2.7.0

[msohn]

I tried updating the jgit packaging build to Tycho 2.7.0 [1] and this failed with the following error [2]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:target-platform-configuration:2.7.0:target-platform (default-target-platform) on project org.eclipse.jgit.repository: Execution default-target-platform of goal org.eclipse.tycho:target-platform-configuration:2.7.0:target-platform failed: Not an artifact file: null

The same build succeeds using Tycho 2.5.0 and 2.6.0.
Any idea what might be wrong?
Build instructions for jgit are documented here [3].
Maven debug log is in [mvn.log]

[1] https://git.eclipse.org/r/c/jgit/jgit/+/191530
[2] https://ci.eclipse.org/jgit/job/stable/job/jgit.gerrit-pipeline.java11/1051/console
[3] https://wiki.eclipse.org/EGit/Contributor_Guide#Maven_Buil
mvn.log

[laeubi]

@msohn thanks for the report I'll try to take a look at this.

[Bananeweizen]

egit/jgit still use the old-school attach-artifact mechanism to dynamically add a target file to the build. I suspect that something around resolving that variable has been broken in 2.7. However, attach-artifact is not necessary anymore. The target of a Tycho build can be specified directly as a file (without referring to a maven artifact) since some versions. My IDE is still trying to get up to date for egit sources, but I might be able to submit a PR later.

[laeubi]

@Bananeweizen the exception is due to org.eclipse.jgit:org.eclipse.jgit:jar:6.2.0-SNAPSHOT:compile is not resolved to a file. I think we should improve the error message here.

I have not yet investigated why that's the case but org/eclipse/jgit/org.eclipse.jgit/6.2.0-SNAPSHOT/org.eclipse.jgit-6.2.0-SNAPSHOT.jar is present so I don't really get why this is not resolved by maven...

[msohn]

I moved this change to master and rebased it onto Michael's change
https://git.eclipse.org/r/c/jgit/jgit/+/191544
directly referring to the target platform file, though this is still failing with the error

[ERROR] Failed to execute goal org.eclipse.tycho:target-platform-configuration:2.7.0:target-platform (default-target-platform) on project org.eclipse.jgit.repository: Execution default-target-platform of goal org.eclipse.tycho:target-platform-configuration:2.7.0:target-platform failed: Not an artifact file: null

[laeubi]

@msohn I don't think this is related to the target, neverless you should integrate @Bananeweizen patch as it is more "modern" style of using targets with tycho.

Beside this, #727 should fix the issue (even though I don't know why it is required at all).

[msohn]

I merged Michael's patches using modern style of using target platforms

Looking forward to your fix.

[laeubi]

Can you try out the current tycho snapshot build if it fixes your issue?

[msohn]

I can confirm that the jgit build succeeds with the current tycho 3.0.0-SNAPSHOT

[msohn]

is there an ETA for a release containing this fix ?

[mickaelistria]

Doing a release is a major disturbance and slows down a lot of other development. The other question would be: can you deal with 3.0.0-SNAPSHOT until it's released as 3.0.0 ?

[msohn]

I can stick to 2.5.0 or update to 2.6.0 until 3.0 is ready

[laeubi]

@msohn in generall it really helps if projects using tycho help with testing of upcoming versions, so If you can either always use the snapshot or at least have a weekly build that uses a snapshot that would be great to discover such issues before the release.

[laeubi]

@msohn I wonder if you probably use <exclusion> in your build somewhere? As i think that it might be that if a transitive dependency is excluded we end up with this null problem ...

[msohn]

yes we do in this module: https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/refs/heads/master/org.eclipse.jgit.junit.ssh/pom.xml#54