-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducer for the .settings folder of a project is not considdered if it is a linked resource #1626
Conversation
@sthdev can you please make sure to sign the ECA? |
I did but there is no connection between my eclipse and my GitHub account. How would I do this? |
In your eclipse profile you can add the github user name, you must also make sure that the mail of the commit is the one you signed the ECA with. |
Well, that's a problem. I did not sign the commits and I used a fake git user for technical reasons. I'll have to recommit the changes but I will not get around to do it before next week. |
ec063ee
to
043a938
Compare
The commit email matches the ECA mail, now. |
Test Results 591 files 591 suites 4h 2m 51s ⏱️ Results for commit a247c08. ♻️ This comment has been updated with latest results. |
043a938
to
a3689a1
Compare
a3689a1
to
7f9cc60
Compare
@sthdev it seems the test does not fail, can you check why it does not gives a failing test? Maybe one can better use a warning in the code, the enable failOnWarning in the settings of tycho but suppress the warning in the project settings. Thsi should then result in a failing compile if project settings are not considered. |
7f9cc60
to
a247c08
Compare
Closing as no feedback from original author. @sthdev if this is still interesting for you please let me know so we can reopen the PR. |
This integration test tests if tycho follows project settings if the
.settings
folder of a project is a linked resource, which refers to another folder.