Add dummy parameter to prevent warnings with jgit as timestamp provider #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven 3.9 complains of "missing" parameters even if we need them for the jgit provider. This adds two dummy parameters so maven is happy again. Fix eclipse-tycho#2080
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven 3.9 complains of "missing" parameters even if we need them for the jgit provider.
This adds two dummy parameters so maven is happy again.
Fix #2080
FYI @Bananeweizen @merks this is a bit band-aid but probably most pragmatic solution until this is refactored in Tycho 5 ...