Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to handle GOAWAY with a retry of the GET call falling back to Http/1 #2696

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Aug 1, 2023

Currently some servers seem overloaded or unhappy with some requests when using Http/2, this adds a fallback to Http/1 if we detect GOAWAY and retry the request.

FYI @merks maybe we can use similar for the ECF implementaion, I was not yet able to see GOAWAY but it seems you was able to reproduce it somehow so maybe you want to give it a try?

Currently some servers seem overloaded or unhappy with some requests
when using Http/2, this adds a fallback to Http/1 if we detect GOAWAY
and retry the request.
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Test Results

   561 files  ±0     561 suites  ±0   4h 46m 57s ⏱️ + 17m 18s
   359 tests ±0     353 ✔️ ±0    6 💤 ±0  0 ±0 
1 077 runs  ±0  1 058 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 05a324a. ± Comparison against base commit 81a3a1b.

@laeubi laeubi merged commit f4833a0 into eclipse-tycho:tycho-4.0.x Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant