Return the maven location for missing junit bundles #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only publish the meta-data, what works for most of the time if a junit bundle is missing, but for the case where the bundle name does not match the artifact key (e.g. junit4/hamcrest) this leads to Tycho not find the file and injecting a dummy file that can confuse maven-surefire-plugin. This now adds a new IRawArtifactFileProvider provider for such missing bundles that is asked as last resort if no other part of the system can answer for a file.
Merged
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only publish the meta-data, what works for most of the time if a junit bundle is missing, but for the case where the bundle name does not match the artifact key (e.g. junit4/hamcrest) this leads to Tycho not find the file and injecting a dummy file that can confuse maven-surefire-plugin.
This now adds a new IRawArtifactFileProvider provider for such missing bundles that is asked as last resort if no other part of the system can answer for a file.