Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2937: Integration test #2975

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Issue 2937: Integration test #2975

merged 1 commit into from
Nov 2, 2023

Conversation

thahnen
Copy link
Contributor

@thahnen thahnen commented Oct 31, 2023

An integration test for #2937 to check if the issue is linked to #2938. They are connected, and the problems are already fixed on the current master.

Running mvn clean verify -Dtycho-version=4.0.3 on this integration test project also shows the issue not being fixed prior.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Nov 1, 2023
@laeubi
Copy link
Member

laeubi commented Nov 1, 2023

@thahnen thanks for the testcase what seem to pass, I plan to merge this if you have not any further adjustments planed.

You can also try out the current tycho snapshot build to verify it with your real build as well.

Copy link

github-actions bot commented Nov 1, 2023

Test Results

   567 files  +3     567 suites  +3   4h 2m 9s ⏱️ - 52m 32s
   369 tests +1     363 ✔️ +1    6 💤 ±0  0 ±0 
1 107 runs  +3  1 088 ✔️ +3  19 💤 ±0  0 ±0 

Results for commit fccc435. ± Comparison against base commit f8e6288.

@thahnen
Copy link
Contributor Author

thahnen commented Nov 2, 2023

Hi @laeubi, I have no further adjustments planned. I've tested briefly with the current Tycho snapshot build and it seems to work fine!

@laeubi laeubi merged commit 84b53d0 into eclipse-tycho:master Nov 2, 2023
11 checks passed
Copy link

github-actions bot commented Nov 2, 2023

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants