Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if artifact exits before attach it to not get warned by maven #3116

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 4, 2023

MavenProjectHelper claims it can replace artifacts but this generates a warning for the user, to prevent this we now check for an already attached artifact and simply update the file (even though it should already point to the right one).

MavenProjectHelper claims it can replace artifacts but this generates a
warning for the user, to prevent this we now check for an already
attached artifact and simply update the file (even though it should
already point to the right one).
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Test Results

   570 files  ±0     570 suites  ±0   3h 49m 13s ⏱️ + 18m 15s
   374 tests ±0     366 ✔️  - 2    6 💤 ±0  0 ±0  2 🔥 +2 
1 122 runs  ±0  1 101 ✔️  - 2  19 💤 ±0  0 ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit f72881f. ± Comparison against base commit ca5b976.

@laeubi laeubi merged commit 2c27d42 into eclipse-tycho:master Dec 4, 2023
7 of 11 checks passed
Copy link

github-actions bot commented Dec 4, 2023

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant